Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code-lens to run pipeline #606

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Add code-lens to run pipeline #606

merged 8 commits into from
Jul 31, 2024

Conversation

georg-schwarz
Copy link
Member

@georg-schwarz georg-schwarz commented Jul 30, 2024 •
edited
Loading

Closes #587.

Adds a Run (once) code lens over each pipeline that executes the jv CLI.

image

rhazn
rhazn approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@rhazn rhazn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the effects are of the directory logic changing in the run-action.ts, if you're confident in that change I'd trust your knowledge though.

Other comments are largely just style and can be ignored.

apps/vs-code-extension/src/commands/run-jv.ts Outdated Show resolved Hide resolved
apps/vs-code-extension/src/commands/run-jv.ts Outdated Show resolved Hide resolved
apps/interpreter/src/run-action.ts Show resolved Hide resolved
libs/language-server/src/lib/lsp/jayvee-code-lens-provider.ts Outdated Show resolved Hide resolved
libs/language-server/src/lib/lsp/jayvee-code-lens-provider.ts Outdated Show resolved Hide resolved
apps/vs-code-extension/src/commands/run-jv.ts Show resolved Hide resolved
@georg-schwarz georg-schwarz merged commit 7a512a1 into main Jul 31, 2024
3 checks passed
@georg-schwarz georg-schwarz deleted the 587-vscode-run-pipeline-action branch July 31, 2024 08:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhazn rhazn rhazn approved these changes

@joluj joluj Awaiting requested review from joluj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] VSCode Extension: Run pipeline button
2 participants
@georg-schwarz @rhazn